Ensure target is reset before loading a jdk pipeline config file #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
github-actions
bot
added
generation
|
run tests |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
PR TESTER RESULT ✅ All pipelines passed! ✅ |
tellison
approved these changes
Aug 11, 2023
sxa
approved these changes
Aug 11, 2023
luhenry
pushed a commit
to luhenry/adoptium-ci-jenkins-pipelines
that referenced
this pull request
Feb 3, 2024
…ptium#774) * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> * Ensure target is reset before loading a jdk pipeline config file Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #773
When pipeline config is loaded via a groovy "target = load ", target is set to the current groovy binding, and all the variables loaded are set in the groovy variable binding.
When a 2nd load is performed the target return is the same "current groovy binding", thus any previous version loaded variable values will still be set... hence why the jdk21 schedule was being set to the jdk17u schedule!
This PR ensures at the end of each iteration the target binding values are reset.